Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add modern help and examples in task csv-to-oscal-cd tutorials #1738

Closed
wants to merge 3 commits into from

Conversation

degenaro
Copy link
Collaborator

Types of changes

  • Hot fix (emergency fix and release)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (change which affects the documentation site)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Release (develop -> main)

Quality assurance (all should be covered).

  • My code follows the code style of this project.
  • Documentation for my change is up to date?
  • My PR meets testing requirements.
  • All new and existing tests passed.
  • All commits are signed-off.

Summary

Key links:

Before you merge

  • Ensure it is a 'squash commit' if not a release.
  • Ensure CI is currently passing
  • Check sonar. If you are working for a fork a maintainer will reach out, if required.

@degenaro degenaro self-assigned this Oct 23, 2024
@degenaro degenaro added documentation Improvements or additions to documentation transforms Relates to a format transformation or extrapolation demos labels Oct 23, 2024
Copy link
Collaborator

@butler54 butler54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes make sense to me, however, this needs to be rebased on the latest file structures

@@ -0,0 +1,3 @@
# Examples: csv files suitable for csv-to-oscsl-cd transformation
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a title and description block in the new file

@jpower432 jpower432 added this to the v3.6.0 milestone Nov 5, 2024
@degenaro
Copy link
Collaborator Author

degenaro commented Nov 6, 2024

Superceded by #1745

@degenaro degenaro closed this Nov 6, 2024
@degenaro degenaro deleted the fix/csv-to-oscal-cd-doc branch November 6, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
demos documentation Improvements or additions to documentation transforms Relates to a format transformation or extrapolation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants