Added <label> tags; tweaked spelling, grammar and readability #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added <label> tags around a couple of elements that were lacking them on the open ticket page. Makes elements easier to click (and adds consistency).
osTicket would benefit <label>s across the board. I created a regex for it, but it was still slow going due to the expected formatting irregularities and the like, so I just did the settings subtabs.
Tweaked spelling, grammar and wording to make the text of the upgrader pages more readable.
Higly —> Highly
Fixed some spelling mistakes.
More fies.
|
@drewx0r, thank you very much for taking to time to post grammar corrections. This commit doesn't follow our usual model of pulling from a branch other than develop and contains fixes to XHTML I'm not ready to pull yet. While I agree there are some issues with the XHTML the system generates, we're going to overhaul the entire system with a template-based one. I'd prefer to get your feedback once we start that process. I rebased your edits against the newest develop branch and will post a pull request very shortly for the grammar corrections. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Went through and added tags to the new staff ticket and all of the subtabs of the Settings tab in the Staff panel. I'm sure there are other pages that could benefit from the addition of tags (large click targets are so hot right now), but I thought I'd start with the ones I use most.