Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automaticly showing inline Images in Post Body #159

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Automaticly showing inline Images in Post Body #159

wants to merge 10 commits into from

Conversation

Bastian-Kuhn
Copy link
Contributor

Showing of inline images in body text from ticket posts.

For us a very useful future, cause many customers send us inline attachments with screenshots from the problems they have.

@@ -1318,6 +1318,10 @@ time {
border:1px solid #a00;
}

.ineline_image {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you misspell this no purpose?

@greezybacon
Copy link
Contributor

I really like this idea. I would prefer to see

  • attachments inlined by the MIME content-type instead of the extension
  • the list of inlined attachment types configurable (in ost-config.php or via the web interface)
  • the Ticket::getAttachmentUrls() method merged with Ticket::getAttachmentsLinks() so we don't have yet another place where attachment URL hashes are generated

@Bastian-Kuhn
Copy link
Contributor Author

Hello,

i'm currently for a consulting in malysia,
i will fix all at the latest, when i'm back in germany.

@Bastian-Kuhn
Copy link
Contributor Author

Hello,

i just fixed the typos and merged the getAttachmentUrls wird the getAttachmentsLinks function.

For attachments inlined by the MIME content-type instead of the extension: I think that the effort here is to high in relation to the advantage, because we only deal with images an no other filetypes. (If you really want it this way, i change it of course)

the list of inlined attachment types configurable (in ost-config.php or via the web interface:
Yes, but i think an simple on or off are enough. We currently only have images here.
For a config option via web interface, it needs an update in the database scheme. How can i apply such an update?

@n0rb
Copy link

n0rb commented Feb 24, 2014

why has this never been merged?

@greezybacon
Copy link
Contributor

This is a major feature of osTicket/osTicket-1.8. It creates several cascading issues, so we decided to leave it out of 1.7. Users who wish not to use the HTML feature can remain on osTicket 1.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants