Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

Cleaning codebase #201

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

KossakowskaKarolina
Copy link
Contributor

Things done:

  1. Css:
  • Unified units of size (px), colors (hex) and font weight.
  • Changed name of file: 'login.css' suggested it applies only to 'login.html' file. I changed it to 'views.css'.
  • Removed non existing classes.
  • Removed properties that were overwritten by bootstrap classes.
  1. Html: removed trailing slash on void elements, fixed indentations.

  2. JS:

  • Global variables moved to top.
  • Unified names of variables. I changed all to camelCase. I changed some variables' names that were unclear.
  • Var changed to let.
  • Added comments to functions describing what they're doing.

General:

  • Commented code and console logs removed.
  • Fixed spacing and indentations.

If something needs clarification or further fixing, please let me know.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant