feat(upload): handle uploading folders and multiple files

[Dorosty]

• requires feat(dnd): add configurable dataTransferProperty to droppable osjs-client#213
• progressDialog has been changed to take a string instead of a file, so that when we are uploading multiple files, the title of the dialog would be 'Uploading multiple files...'
• uploadBrowserFiles has been completely re-implemented to allow uploading multiple files, and also recursively handling folders and their content.

[Dorosty]

This branch #45 adds support for uploading folders from the menu. Hopefully it can be merged after this.

[Dorosty]

If there's anything I can do to help make this easier to review, please let me know (e.g. breaking this PR into smaller ones)

[andersevenrud]

This looks pretty good @Dorosty! Haven't had a chance to fully very everything because I started a new job last week and been insanely busy. Things are now finally cooling down though, so I'll take a closer look and get back to you ASAP.

[andersevenrud]

Another contributor brought up a relevant issue recently: os-js/OS.js#847

[Dorosty]

This looks pretty good @Dorosty! Haven't had a chance to fully very everything because I started a new job last week and been insanely busy. Things are now finally cooling down though, so I'll take a closer look and get back to you ASAP.

Congratulations & TYSM 🙏

[Dorosty]

Another contributor brought up a relevant issue recently: os-js/OS.js#847

This would require a change in the system vfs adapter in osjs-client, which would require multiple PRs. May I suggest we merge this one first & then I will add the cancellability feature in separate PRs.

[andersevenrud]

May I suggest we merge this one first

Hmm. I kinda feel like cancellation should be added first, but there's nothing really in the way to take this one first.

[Dorosty]

May I suggest we merge this one first

Hmm. I kinda feel like cancellation should be added first, but there's nothing really in the way to take this one first.

• 4a102e1
• feat: add support for AbortController signal in writeFile osjs-client#216

[Dorosty]

May I suggest we merge this one first

Hmm. I kinda feel like cancellation should be added first, but there's nothing really in the way to take this one first.

This is done BTW

[andersevenrud]

Finally found some time to test this out (on various platforms). Seems to be working great!

I just have one final comment that came to mind while testing. It would be really nice if this feature could be set via a configuration that defaults to true (like filemanager.disableDownload). Could really make use of that on my demo server :)

[Dorosty]

I just have one final comment that came to mind while testing. It would be really nice if this feature could be set via a configuration that defaults to true (like filemanager.disableDownload). Could really make use of that on my demo server :)

Would this be a good config schema?

filemanager: {
  uploadMethod: 'single' | 'multiple',
}

[andersevenrud]

Just a simple boolean would suffice: filemanager.disableMultiUpload or something like that.

[Dorosty]

Just a simple boolean would suffice: filemanager.disableMultiUpload or something like that.

Done! 🎉 please note that os-js/osjs-client#216 should also be merged for AbortController to work.

[ajmeese7]

Could you capitalize this comment? Other than that, looks great!