openqa-bats-review: Update expected outside of loop#523
Merged
mergify[bot] merged 2 commits intoos-autoinst:masterfrom Feb 10, 2026
Merged
openqa-bats-review: Update expected outside of loop#523mergify[bot] merged 2 commits intoos-autoinst:masterfrom
mergify[bot] merged 2 commits intoos-autoinst:masterfrom
Conversation
9421f85 to
aa4188a
Compare
Martchus
reviewed
Feb 10, 2026
Contributor
Author
It's a fix and I think the current commit message states the intention. |
We were updating the expected dict when iterating on the job list. We should do this once and it's safe to do so because get_job() is cached.
aa4188a to
27bd2d0
Compare
perlpunk
approved these changes
Feb 10, 2026
27bd2d0 to
ea10423
Compare
okurz
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were updating the
expecteddict when iterating over the job list!We should do this once and it's safe to do so because get_job() is cached.
Also enhance the logging that helped catch this.
Otherwise we get: