Revert recent changes regarding osc invocations#520
Revert recent changes regarding osc invocations#520mergify[bot] merged 4 commits intoos-autoinst:masterfrom
Conversation
|
Yeah, I guess to regex is probably too permissive :( |
|
Yes, the regex is too generic. |
|
This pull request is now in conflicts. Could you fix it? 🙏 |
feed459 to
d497891
Compare
|
Maybe we should revert previous changes via this PR considering the deleted changelog lines in https://build.opensuse.org/package/rdiff/devel:openQA:tested/openQA. Note that the build of os-autoinst still fails due to invalid characters but it hasn't been updated by the submission script. So @perlpunk's revision 350 is still the most recent on https://build.opensuse.org/package/revisions/devel:openQA:tested/os-autoinst and it just didn't remove all control characters. So I removed the remaining control characters I could find. |
|
Although I'm also not completely confident whether reverting this now will actually help with the log deletions in the openQA package. Maybe we'll have to restore some piece of information elsewhere which is our actual problem. |
With the latest fix there are no broken characters anymore but I saw this PR which has many deleted changelog lines: https://src.opensuse.org/pool/os-autoinst/pulls/14#issuecomment-88805
Note sure whether that's still due to the recent changes. In case it turns out to be the case I've prepared this PR so we can go back to the previous state.
Related ticket: https://progress.opensuse.org/issues/195695