Merge pull request #5755 from okurz/enhance/signatures12

Use signatures in Shared::Controller::Running

lib/OpenQA/Shared/Controller/Running.pm

@@ -111,14 +111,14 @@ sub streamtext ($self, $file_name, $start_hook = undef, $close_hook = undef) {
     # Check for new lines from the logfile using recurring timer
     # Setup utility function to close the connection if something goes wrong
     my $timer_id;
-    my $close_connection = sub {
+    my $close_connection = sub ($self) {
         Mojo::IOLoop->remove($timer_id);
         $close_hook->();
         $self->finish;
         close $log;
     };
     $timer_id = Mojo::IOLoop->recurring(
-        TEXT_STREAMING_INTERVAL() => sub {
+        TEXT_STREAMING_INTERVAL() => sub (@) {
             if (!$ino) {
                 # log file was not yet opened
                 return unless open($log, '<', $logfile);
@@ -146,7 +146,7 @@ sub streamtext ($self, $file_name, $start_hook = undef, $close_hook = undef) {
 
     # Stop monitoring the logfile when the connection closes
     $self->on(
-        finish => sub {
+        finish => sub (@) {
             Mojo::IOLoop->remove($timer_id);
             $close_hook->($worker, $job);
         });
@@ -157,8 +157,7 @@ sub livelog ($self) {
     $self->streamtext('autoinst-log-live.txt');
 }
 
-sub liveterminal {
-    my ($self) = @_;
+sub liveterminal ($self) {
     return 0 unless $self->init();
     $self->streamtext('serial-terminal-live.txt');
 }