Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: expression ordering #1529

Closed
wants to merge 1 commit into from
Closed

Conversation

hperl
Copy link
Collaborator

@hperl hperl commented Jun 4, 2024

This is an attempt to reproduce #1522

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@hperl hperl requested review from zepatrik and alnr as code owners June 4, 2024 07:05
@hperl hperl force-pushed the hperl/expression-ordering-repro branch from aeee00c to f430843 Compare June 4, 2024 07:18
@hperl hperl added the no-close Do not close this. label Jun 4, 2024
@rbnbr rbnbr mentioned this pull request Jun 4, 2024
7 tasks
@aeneasr
Copy link
Member

aeneasr commented Jul 4, 2024

Can this be merged?

@hperl
Copy link
Collaborator Author

hperl commented Jul 26, 2024

This was an attempt to reproduce an issue that was not a bug after all. We expanded the test suite in another PR anyways.

@hperl hperl closed this Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-close Do not close this.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants