Skip to content

Conversation

@Armanio
Copy link
Contributor

@Armanio Armanio commented Nov 28, 2025

closes #2459

  • Change enum consts generation
  • drop unless eslint commit
  • update samples

PS: if anyone can suggest a better title for the enum, I'm ready to listen

@Armanio Armanio changed the title Change enum generation fix(core): change enum generation Nov 29, 2025
@Armanio Armanio marked this pull request as draft November 29, 2025 03:31
@Armanio Armanio changed the title fix(core): change enum generation fix(core): change enum consts generation Nov 29, 2025
@melloware
Copy link
Collaborator

Can you rebase this it is conflicted now after the recent PR merges

@anymaniax
Copy link
Collaborator

anymaniax commented Dec 14, 2025

It's a big breaking change no? Also I am not a big fan of just adding Const to it. It's all interest of the enum to have the same name as the type. I have the impression that it's a standard way of doing it like we do it currently. We should maybe find a way to avoid the error for all the linter

@Armanio
Copy link
Contributor Author

Armanio commented Dec 15, 2025

@anymaniax Yes, you're right. This is a breaking change. I was thinking about adding different comments depending on the linter, but I'm not sure that's a good approach. Separating actual values ​​and TypeScript types can be convenient, for example, for searching for values ​​in code.

Anyway, this is a draft; I'm currently running into issues importing types from one file to another.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Same Naming & Eslint comment

3 participants