Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration fixes #265

Open
wants to merge 2 commits into
base: 5.1
Choose a base branch
from
Open

Conversation

jimohalloran
Copy link

Two updates to the pgloader configuration that appears in the MySQL to Postgresql migration guide:

  • Add an extra typecast to ensure that signed int primary keys are converted correctly. Where unsigned units are used as the primary key (4 audit tables and a handful of other core Oro tables), they converted correctly into a bigint + sequence. But signed ints (the vast majority of tables) converted to ints with a primary key constraint and no sequence for autoincrementing. Full credit to @AdamJHall for this fix, this was his work. I've been able to test it and confirm it working.
  • Limit the number of rows to prefetch to reduce heap usage. This avoids a "Heap exhausted" error on conversion. Given that Adam and I both had the same issue , and arrived at the same fix separately, this should probably be in the default config?

These two fixes are provided in separate commits so you can take or leave them individually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant