feat: compatibility with doctrine orm 3.0 minimum #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
|
|
@x86demon can you rebase branch 3.x with master ? |
|
Hi @Gwemox. master mostly contains in-development features that are planned for next release. What functionality do you need in 3.x? Maybe I can cherry-pick some commits or adopt PR for 3.x? |
Add CI? |
|
CI was ported to 2.x and 3.x |
Gwemox
force-pushed
the
feat/upgrade-doctrine-orm-3
branch
2 times, most recently
from
e409b58
to
f6d5d2f
Compare
Gwemox
force-pushed
the
feat/upgrade-doctrine-orm-3
branch
from
f6d5d2f
to
b221630
Compare
|
It's OK, you can check the code. |
|
Up @x86demon ? 👼 |
|
Hi @Gwemox. Thank you for the PR |
Closed
|
Would be great if this could get merged and released. It's the last compatibility blocker for me 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the extension to be compatible with Doctrine 3.0, which is now the minimum required version. I had to remove support for ArrayType and ObjectType, as they are no longer natively supported by Doctrine.
All tests pass.