Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set requirement for doctrine/lexer #96

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

alexander-schranz
Copy link
Contributor

@alexander-schranz alexander-schranz commented Jan 28, 2024

The doctrine/lexer 3 is incompatible but doctrine/orm 2.18 will be using it. The doctrine/lexer was not used before 2.10 of the orm which requires dbal 2.10 that is why that requirements also. Before lexer was part of the old doctrine/common before the lexer got in its own package.

See also: doctrine/orm#11192

@alexander-schranz
Copy link
Contributor Author

@x86demon Thx for merging, do you know when the next release is planned. Would be great this is tagged before orm 2.18 is released to avoid problems if people upgrade there projects to avoid they get accidently lexer 3.

@x86demon
Copy link
Collaborator

x86demon commented Feb 1, 2024

@alexander-schranz , thank you for contribution.
Tagged it as new pre-release 3.0-alpha3

@alexander-schranz
Copy link
Contributor Author

alexander-schranz commented Feb 1, 2024

Is it possible todo a 2.x release with this fix. Else doctrine/orm 2.18 would break the current stable 2.x version. If not possible it also fine then I will add a conflict on our side to doctrine/lexer 3 to avoid this problem.

@x86demon
Copy link
Collaborator

x86demon commented Feb 5, 2024

I'd prefer to keep v2 with old dependencies and limit the maximum doctrine version there to not break other project.
v3 will introduce doctrine 3 support.

@alexander-schranz
Copy link
Contributor Author

alexander-schranz commented Feb 5, 2024

@x86demon thats what this pull request does :) keep things work on 2.0, avoid that doctrine/lexer 3 is installed where it does crash currently as it is not defined there:

/home/runner/work/sulu/sulu/vendor/oro/doctrine-extensions/src/Oro/ORM/Query/AST/Functions/String/GroupConcat.php:46
/home/runner/work/sulu/sulu/vendor/doctrine/orm/src/Query/Parser.php:3662
/home/runner/work/sulu/sulu/vendor/doctrine/orm/src/Query/Parser.php:3526
/home/runner/work/sulu/sulu/vendor/doctrine/orm/src/Query/Parser.php:3491
/home/runner/work/sulu/sulu/vendor/doctrine/orm/src/Query/Parser.php:2273
/home/runner/work/sulu/sulu/vendor/doctrine/orm/src/Query/Parser.php:1217
/home/runner/work/sulu/sulu/vendor/doctrine/orm/src/Query/Parser.php:881
/home/runner/work/sulu/sulu/vendor/doctrine/orm/src/Query/Parser.php:850
/home/runner/work/sulu/sulu/vendor/doctrine/orm/src/Query/Parser.php:257
/home/runner/work/sulu/sulu/vendor/doctrine/orm/src/Query/Parser.php:357
/home/runner/work/sulu/sulu/vendor/doctrine/orm/src/Query.php:276
/home/runner/work/sulu/sulu/vendor/doctrine/orm/src/Query.php:288
/home/runner/work/sulu/sulu/vendor/doctrine/orm/src/AbstractQuery.php:1212
/home/runner/work/sulu/sulu/vendor/doctrine/orm/src/AbstractQuery.php:1166
/home/runner/work/sulu/sulu/vendor/doctrine/orm/src/AbstractQuery.php:913
/home/runner/work/sulu/sulu/src/Sulu/Component/Rest/ListBuilder/Doctrine/DoctrineListBuilder.php:297
/home/runner/work/sulu/sulu/src/Sulu/Bundle/ContactBundle/Controller/ContactController.php:340
/home/runner/work/sulu/sulu/src/Sulu/Bundle/ContactBundle/Controller/ContactController.php:318
/home/runner/work/sulu/sulu/src/Sulu/Bundle/ContactBundle/Controller/ContactController.php:262
/home/runner/work/sulu/sulu/vendor/symfony/http-kernel/HttpKernel.php:181
/home/runner/work/sulu/sulu/vendor/symfony/http-kernel/HttpKernel.php:76
/home/runner/work/sulu/sulu/vendor/symfony/http-kernel/Kernel.php:197
/home/runner/work/sulu/sulu/vendor/symfony/http-kernel/HttpKernelBrowser.php:65
/home/runner/work/sulu/sulu/vendor/symfony/framework-bundle/KernelBrowser.php:175
/home/runner/work/sulu/sulu/vendor/symfony/browser-kit/AbstractBrowser.php:385
/home/runner/work/sulu/sulu/src/Sulu/Bundle/TestBundle/Kernel/SuluKernelBrowser.php:57
/home/runner/work/sulu/sulu/src/Sulu/Bundle/ContactBundle/Tests/Functional/Controller/AccountControllerTest.php:1532

Using the new deps would be then in #97

@x86demon
Copy link
Collaborator

x86demon commented Feb 5, 2024

Thank you very much. I'll schedule the review for this week.
✔️ - done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants