-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set requirement for doctrine/lexer #96
Conversation
@x86demon Thx for merging, do you know when the next release is planned. Would be great this is tagged before orm 2.18 is released to avoid problems if people upgrade there projects to avoid they get accidently lexer 3. |
@alexander-schranz , thank you for contribution. |
Is it possible todo a 2.x release with this fix. Else doctrine/orm 2.18 would break the current stable 2.x version. If not possible it also fine then I will add a conflict on our side to doctrine/lexer 3 to avoid this problem. |
I'd prefer to keep v2 with old dependencies and limit the maximum doctrine version there to not break other project. |
@x86demon thats what this pull request does :) keep things work on 2.0, avoid that doctrine/lexer 3 is installed where it does crash currently as it is not defined there:
Using the new deps would be then in #97 |
Thank you very much. I'll schedule the review for this week. |
The doctrine/lexer 3 is incompatible but doctrine/orm 2.18 will be using it. The doctrine/lexer was not used before 2.10 of the orm which requires dbal 2.10 that is why that requirements also. Before lexer was part of the old doctrine/common before the lexer got in its own package.
See also: doctrine/orm#11192