Add lexer 3 support to 2.x branch #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odolbeau
approved these changes
Jul 9, 2024
|
Would be awesome if we could get this merged |
|
@x86demon can you have a look at this? |
x86demon
approved these changes
Nov 20, 2024
|
@x86demon thank you! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This make backports the lexer 3 support to 2.x branch to support too keep the supported verson constraint of 2.x branch as wide as possible.
Adds suggestion fron @Gwemox from here: #97 (comment)
Support for ORM 3 and DBAL 4 is part of the 3.x / master version and will not be backported to 2.x as that would require to much bc layers that make things just unreadable and hard to maintain tested that in #97, which introduce the widest version constraint without a lot of effort for 3.x / master branch.