Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add github ci #100

Merged
merged 7 commits into from
Apr 19, 2024
Merged

feat: add github ci #100

merged 7 commits into from
Apr 19, 2024

Conversation

Gwemox
Copy link
Contributor

@Gwemox Gwemox commented Apr 18, 2024 •
edited
Loading

Here is a functional CI with Github Actions. It has helped me identify several issues:

  • The PHP minimum version is 8.1 in the composer.json, while the tests were on 7.3 and 7.4. And the documentation still displays 7.3 as the minimum.
  • We were trying to test a JSON CAST for MariaDB when it is not available.

@Gwemox Gwemox force-pushed the feat/github-actions branch 9 times, most recently from 0495e1b to e0a0eb2 Compare April 18, 2024 18:03
@Gwemox Gwemox changed the title DRAFT: feat: add github ci feat: add github ci Apr 18, 2024
@Gwemox Gwemox mentioned this pull request Apr 18, 2024
Open
1 task
x86demon
x86demon requested changes Apr 19, 2024
View reviewed changes
tests/Oro/Tests/ORM/AST/Query/Functions/fixtures/mysql/cast.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
x86demon
x86demon requested changes Apr 19, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
tests/Oro/Tests/ORM/AST/Query/Functions/fixtures/mysql/cast.yml Outdated Show resolved Hide resolved
@Gwemox Gwemox requested a review from x86demon April 19, 2024 14:53
@x86demon x86demon merged commit 4e1923f into oroinc:master Apr 19, 2024
3 checks passed
@x86demon
Copy link
Collaborator

@Gwemox Thank you very much for your contribution. Great job 🥇

x86demon added a commit that referenced this pull request Apr 24, 2024
@x86demon
Merge pull request #102 from oroinc/2.x-ci
1cf09fd 
add github ci PR #100 2.x
x86demon added a commit that referenced this pull request Apr 24, 2024
@x86demon
Merge pull request #101 from oroinc/3.x-ci
072d0d8 
port CI to 3.x from PR #100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@x86demon x86demon x86demon approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gwemox @x86demon