CI for 2.x compatibility

oroinc · Apr 24, 2024 · c0d8e54 · c0d8e54
1 parent 80747e1
commit c0d8e54
Show file tree

Hide file tree

Showing 3 changed files with 52 additions and 51 deletions.
diff --git a/src/Oro/ORM/Query/AST/FunctionFactory.php b/src/Oro/ORM/Query/AST/FunctionFactory.php
@@ -3,9 +3,6 @@
 
 namespace Oro\ORM\Query\AST;
 
-use Doctrine\DBAL\Platforms\AbstractPlatform;
-use Doctrine\DBAL\Platforms\MySQLPlatform;
-use Doctrine\DBAL\Platforms\PostgreSQLPlatform;
 use Doctrine\ORM\Query\QueryException;
 use Oro\ORM\Query\AST\Platform\Functions\PlatformFunctionNode;
 
@@ -16,24 +13,8 @@ class FunctionFactory
      *
      * @throws QueryException
      */
-    public static function create(
-        AbstractPlatform $platform,
-        string $functionName,
-        array $parameters
-    ): PlatformFunctionNode {
-        if ($platform instanceof PostgreSQLPlatform) {
-            $platformName = 'postgresql';
-        } elseif ($platform instanceof MySQLPlatform) {
-            $platformName = 'mysql';
-        } else {
-            throw QueryException::syntaxError(
-                \sprintf(
-                    'Not supported platform "%s"',
-                    $platform::class
-                )
-            );
-        }
-
+    public static function create(string $platformName, string $functionName, array $parameters): PlatformFunctionNode
+    {
         $className = __NAMESPACE__
             . '\\Platform\\Functions\\'
             . static::classify(\strtolower($platformName))

diff --git a/tests/config/mysql.phpunit.xml b/tests/config/mysql.phpunit.xml
@@ -1,17 +1,27 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" backupGlobals="false" colors="false" stopOnFailure="false" bootstrap="../bootstrap.php" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.3/phpunit.xsd" cacheDirectory=".phpunit.cache" backupStaticProperties="false">
-  <php>
-    <var name="db_type" value="pdo_mysql"/>
-    <var name="db_host" value="127.0.0.1"/>
-    <var name="db_username" value="u_doctrine_extensions"/>
-    <var name="db_password" value="myPassword"/>
-    <var name="db_name" value="doctrine_extensions_tests"/>
-    <var name="db_port" value="3306"/>
-  </php>
-  <testsuites>
-    <testsuite name="Oro Doctrine Extensions Test Suite">
-      <directory>../Oro/Tests/ORM</directory>
-      <directory>../Oro/Tests/DBAL</directory>
-    </testsuite>
-  </testsuites>
+
+<phpunit backupGlobals="false"
+         backupStaticAttributes="false"
+         colors="false"
+         convertErrorsToExceptions="true"
+         convertNoticesToExceptions="true"
+         convertWarningsToExceptions="true"
+         stopOnFailure="false"
+         bootstrap="../bootstrap.php"
+>
+    <php>
+        <var name="db_type" value="pdo_mysql"/>
+        <var name="db_host" value="127.0.0.1" />
+        <var name="db_username" value="u_doctrine_extensions" />
+        <var name="db_password" value="myPassword" />
+        <var name="db_name" value="doctrine_extensions_tests" />
+        <var name="db_port" value="3306"/>
+    </php>
+
+    <testsuites>
+        <testsuite name="Oro Doctrine Extensions Test Suite">
+            <directory>../Oro/Tests/ORM</directory>
+            <directory>../Oro/Tests/DBAL</directory>
+        </testsuite>
+    </testsuites>
 </phpunit>
diff --git a/tests/config/pgsql.phpunit.xml b/tests/config/pgsql.phpunit.xml
@@ -1,17 +1,27 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" backupGlobals="false" colors="false" stopOnFailure="false" bootstrap="../bootstrap.php" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.3/phpunit.xsd" cacheDirectory=".phpunit.cache" backupStaticProperties="false">
-  <php>
-    <var name="db_type" value="pdo_pgsql"/>
-    <var name="db_host" value="localhost"/>
-    <var name="db_username" value="u_doctrine_extensions"/>
-    <var name="db_password" value="myPassword"/>
-    <var name="db_name" value="doctrine_extensions_tests"/>
-    <var name="db_port" value="5432"/>
-  </php>
-  <testsuites>
-    <testsuite name="Oro Doctrine Extensions Test Suite">
-      <directory>../Oro/Tests/ORM</directory>
-      <directory>../Oro/Tests/DBAL</directory>
-    </testsuite>
-  </testsuites>
+
+<phpunit backupGlobals="false"
+         backupStaticAttributes="false"
+         colors="false"
+         convertErrorsToExceptions="true"
+         convertNoticesToExceptions="true"
+         convertWarningsToExceptions="true"
+         stopOnFailure="false"
+         bootstrap="../bootstrap.php"
+>
+    <php>
+        <var name="db_type" value="pdo_pgsql"/>
+        <var name="db_host" value="localhost" />
+        <var name="db_username" value="u_doctrine_extensions" />
+        <var name="db_password" value="myPassword" />
+        <var name="db_name" value="doctrine_extensions_tests" />
+        <var name="db_port" value="5432"/>
+    </php>
+
+    <testsuites>
+        <testsuite name="Oro Doctrine Extensions Test Suite">
+            <directory>../Oro/Tests/ORM</directory>
+            <directory>../Oro/Tests/DBAL</directory>
+        </testsuite>
+    </testsuites>
 </phpunit>