Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix feat: Reorganized builtins to be in the top of stack at the end of run. #1

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Fix feat: Reorganized builtins to be in the top of stack at the end of run. #1

merged 2 commits into from
Mar 27, 2024

Conversation

fmoletta
Copy link

Fixes some issues with PR lambdaclass#1686

  • Fixes incorrect values being copied when copying the builtin bases to the end of the execution segment
  • Fixes incorrect stack pointers being fetched in finalize_builtins due to not taking into account the builtin bases being appended to the execution segment when running without proof_mode/append_return_values
  • Fixes incorrect return values being fetched in fetch_return_values due to not taking into account the builtin bases being appended to the execution segment when running without proof_mode/append_return_values

@fmoletta fmoletta mentioned this pull request Mar 27, 2024
Merged
@orizi orizi merged commit 225df3d into orizi:feat/cairo1-run-reorg-builtins Mar 27, 2024
@fmoletta fmoletta deleted the cairo1-run-reorg-builtins-fix branch May 29, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fmoletta @orizi