fix: Adding layers to map without overlays

[jokd]

Fixes #2095
Replaces #2097

The issue was related to visibleLayersControl

[Grammostola]

This works better : ) The only thing I noticed was that it matters whether the visibleLayersViewActive prop is true or not on map start in terms of how added layers appear (things look good if it's not active). If it is things still look better than in the current master, and look good once the visibleLayersControl has been toggled.

[jokd]

This works better : ) The only thing I noticed was that it matters whether the visibleLayersViewActive prop is true or not on map start in terms of how added layers appear (things look good if it's not active). If it is things still look better than in the current master, and look good once the visibleLayersControl has been toggled.

I am unable to reproduce this. To me it doesn't matter what value visibleLayersViewActive has, let go the legend can be a bit less wide when visibleLayersViewActive is true but that is not related to this.

[Grammostola]

Hmm.

So looks my legend def:

      "name": "legend",
      "options": {
        "labelOpacitySlider": "Opacity",
        "useGroupIndication": true,
        "searchLayersControl": true,
        "turnOffLayersControl": true,
        "turnOnLayersControl": true,
        "visibleLayersControl": true,
        "visibleLayersViewActive": true
      }

and here's a gif of when the last param is as it says there above

Perhaps I've compromised the test in some way but I couldn't quickly perceive of how. Am testing the latest jokd:fix-map-without-overlays2

[jokd]

Hmm.

So looks my legend def:

      "name": "legend",
      "options": {
        "labelOpacitySlider": "Opacity",
        "useGroupIndication": true,
        "searchLayersControl": true,
        "turnOffLayersControl": true,
        "turnOnLayersControl": true,
        "visibleLayersControl": true,
        "visibleLayersViewActive": true
      }

and here's a gif of when the last param is as it says there above

Perhaps I've compromised the test in some way but I couldn't quickly perceive of how. Am testing the latest jokd:fix-map-without-overlays2

It is the add layer button that differs and mess things up. I added a layer with the api without that control but I'll have a look at it.

[jokd]

@Grammostola The adding of the add layer button didn't respect the visibleLayersViewActive status ( the row with button, search and eyes shouldn't have been visible nor usable in your example) so when that was active it looked a bit weird. Should work now.

[Grammostola]

True. Works like a charm now.