-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Guide #1831
base: master
Are you sure you want to change the base?
feature: Guide #1831
Conversation
Hi @tonnyandersson, there is still some work to be done on this for the access to the guide.
Any other ideas? |
Looks nice. I would like the guide to be started by the user from the menu, so having it configurable would be great. |
@tonnyandersson This is ready for review. I slimmed it down a bit to only be available through a button. Thinking that if it should be started up when initializing the map it can be done from the splash control. |
I also suggest using Material Icons instead of Font Awesome as much as possible. In this case, it looks like the FA signpost icon gets clipped. The MI equivalent has a better fit out of the box. |
Add logic to show/hide prev/next buttons based on currentIndex in the guide controls. This ensures that the correct buttons are displayed at all times.
Removed the old guide button and replaced it with a new menu item using the "ic_routes_24px" icon to open the modal. This change improves the user experience and aligns with the updated design.
Observers if guide modal is removed from DOM and sets the proper state to guide menu item. If the menu item state is 'initial', it creates a modal and sets the state to 'active'. If the state is 'active', it closes the modal and sets the state back to 'initial'.
@mulfvik Does the latest commits mean that is is ready for a new test? Anyhow, there are merge conflicts. |
@steff-o No, there are still work to do to meet the requirements |
Fix #1019
Config example
{ "name": "guide", "options": { "title": "Guidar dig genom kartan...", "hideButton": { "visible": true } } }
Also see the guide config options in root