Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Twine format to OrganicsMaps usages #13

Draft
wants to merge 5 commits into
base: organicmaps
Choose a base branch
from

Conversation

dwaynebailey
Copy link
Collaborator

This adjust the Twine output format to align with the existing Twine strings.txt in OM

Changes:

  • Space indent instead of tab
  • Dev language after metadata
  • metadata order aligns with existing
  • en-GB follows en

Problems:

  • Plurals are not extracted at all
  • The fancy \n\n in Android is very broken

This aligns with current OrganicMaps structure of:

comment =
tag =
en =
allows:
en =
en-GB =

before alphabetical sorting

Aligns with existing and is more logical
OrganicMaps:
comment =
tags =
ref =
dev-LANG =
other-LANG =

Twine original:
dev-LANG =
ref =
tags =
comment =
other-LANG =

fix
@pastk
Copy link
Member

pastk commented Jan 31, 2025

Do I understand it right that this change is needed to generate Twine/OM strings files from existing android or ios localization files (or other twine-supported formats)?

ATM we don't use this conversion at all, only the opposite (from Twine/OM to native platform localizations).

Is there some idea to use e.g. Android -> Twine conversion?

@rtsisyk
Copy link
Member

rtsisyk commented Feb 23, 2025

Do I understand it right that this change is needed to generate Twine/OM strings files from existing android or ios localization files (or other twine-supported formats)?

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants