Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First go at implementing real time graph tweak #148

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tefkah
Copy link
Collaborator

@tefkah tefkah commented Apr 27, 2021

Hi! I basically stole the real-time physics tweak from here and crudely implemented it in org-roam-server. This allows you to edit the way the graph works in real time, sort of fixing #141

Major todos:

  • Dark mode looks bad, for some reason editing them through the toggle function does not work
  • The thing looks bad in general
  • Currently does not work for the buffer-view, because the way the tweak panel is loaded (through setting some options) would load it again every time you open the buffer view, which is clearly not ideal. Could definitely be fixed
  • The values are not stored on quit
  • The output at the bottom does not provide it in "escaped" JSON, which you could then paste into your emacs config easily

All that said, it does work!

2021-04-28.01-26-57.mp4

@goktug97
Copy link
Member

Hey, this looks awesome. But if I currently merge this I have to maintain it and I can't even look at the other PRs and issues right now due to my studies and job. Are you planning to fix the issues you've listed?

@tefkah
Copy link
Collaborator Author

tefkah commented Apr 30, 2021

Yes I'm planning on fixing these issues over the coming weeks before it would be merged, this is more as a proof of concept. At least the darkmode issue, saving the values on quit and providing escaped JSON should be possible soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants