ENH: add 3d image support to StreamingManager and PipelineMemoryPrint… #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Calculator
Summary
Add nD image support to
otbStreamingManager
and 3D image support toPipelineMemoryPrintCalculator
Rationale
The
StreamingManager
class defines a small, i.e. 100 pixel, region around the image centre that is used to estimate the memory footprint of the processing pipeline. The current implementation only explicitly sets the index for dimensions0
and1
respectively. Since the index value assignment does not account for the actual number of dimensions of the image, a1D
image would produce a segmentation fault when the value ofindex[1]
is assigned.The
PipelineMemoryPrintCalculator
currently only supports2D
images. The number of image dimensions is currently hard coded in::EvaluateDataObjectPrint
in macroOTB_IMAGE_SIZE_BLOCK
.Implementation Details
otbStreamingManager.hxx
smallRegion.Crop(region)
is removed because it is superfluous with the new implementation.otbPipelineMemoryPrintCalculator.cxx
OTB_IMAGE_SIZE_BLOCK
macroCopyright
The copyright owner is Manaaki Whenua - Landcare Research (MWLR). MWLR has signed the ORFEO ToolBox Contributor License Agreement.