Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add info concerning static assets interception to README #155

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zernie
Copy link

@zernie zernie commented Aug 23, 2024

{{PLEASE DELETE ALL PLACEHOLDER VALUES}}

Summary

{{Please provide a brief summary of your work. If this submission is not
referenced by an existing bug or issue, please provide background on what
situation or problem this submission addresses. }}

Related Issue(s)

Issue #{{Issue Number Here}}

Checklist

Add info concerning static assets interception
@zernie zernie requested a review from a team as a code owner August 23, 2024 13:21
@DigTheDoug
Copy link
Contributor

Hi, sorry for the delay in responding. Can you provide more detail on this suggestion? I know it's just a readme change but I get conflicting results on whether this is still necessary with the latest version of Cypress or if the Test Isolation changes. Does it work for any browser or is it Chromium dependent? Should the command be placed within each test, or in a beforeAll? Thanks!

@zernie
Copy link
Author

zernie commented Sep 9, 2024

@DigTheDoug

  1. It is needed with the latest Cypress version.
  2. I have only tested with Electron.
  3. It should be placed in beforeEach

@DigTheDoug
Copy link
Contributor

Thanks. I would make a couple changes to this or we can just make the changes if you aren't currently able to.

I would mention that this example should be used in case of users having trouble with cached assets (I could not reproduce static assets being cached in browser myself, but I believe that it can happen in cases) rather than it being a default. I would mention that this command is an internal command that is Chrome specific, rather than part of the exposed Cypress API so it's subject to possible change, and I would also mention where in tests it should be, i.e. in the beforeEach.

The PR title should also be changed to use Conventional Commit syntax as mentioned in the PR template; that helps us version releases correctly.

@zernie zernie changed the title Update README.md - Add info concerning static assets interception docs - Add info concerning static assets interception to README Sep 11, 2024
@zernie zernie changed the title docs - Add info concerning static assets interception to README docs: Add info concerning static assets interception to README Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants