[#136] Add custom shard count value in concurrent map#137
Open
SeunghoonBaek wants to merge 1 commit intoorcaman:masterfrom
Open
[#136] Add custom shard count value in concurrent map#137SeunghoonBaek wants to merge 1 commit intoorcaman:masterfrom
SeunghoonBaek wants to merge 1 commit intoorcaman:masterfrom
Conversation
|
Agreed. This is a good feature to have and I'm currently waiting for this to be released too. Hope maintainers have no issues with this. |
|
cc: @orcaman for rescue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#136
Hello, what I mentioned in the above issue page, I suggest to use custom shard count for each concurrent map instance.
I would ask you please review this change and let me know how do you think about it? 😃
Thanks a lot!
(Please let me know if I should post more information before posting PR. :-) )
Benchmark result
Test result