Skip to content

Conversation

MischaPanch
Copy link
Contributor

No description provided.

@MischaPanch MischaPanch requested a review from opcode81 July 27, 2025 11:43
@MischaPanch
Copy link
Contributor Author

MischaPanch commented Jul 27, 2025

@opcode81 just have a quick glance pls. No need to review, just informing you that I did this chore.
Resolved something like 250 mypy failures on solidlsp and included it into poe type-check.

The reason is that mypy helps Claude in performing refactorings in solidlsp without running tests. The last refactoring where SolidLSPSettings were added would have been much smoother with this. Claude did manage to make it right in the end, but it took forever and consumed tons of tokens.

It might add minimal value for us, or some minor annoyances (as usual with mypy), but IMO worth the price for having automated and fast feedback for coding agents working on serena.

opcode81 added 2 commits July 27, 2025 23:48
Conflicts:
	src/solidlsp/ls.py
	src/solidlsp/ls_handler.py
	src/solidlsp/ls_request.py
@opcode81
Copy link
Contributor

After merging main and fixing a few issues, some still remain (pertaining to diagnostics).

@MischaPanch
Copy link
Contributor Author

@jetbrains-junie

Resolve conflicts with main and finish fixing typing errors. You can generously apply type: ignore where needed.
Make sure uv run poe type-check and uv run poe test run through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants