Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: install libffi7 manually #964

Merged
merged 4 commits into from
Jan 23, 2025
Merged

Conversation

benmss
Copy link
Member

@benmss benmss commented Jan 17, 2025

An alternative solution to the problem with Souffle and Ubuntu 24.04: Installing the libffi7 library manually. See #962

@benmss benmss self-assigned this Jan 17, 2025
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 17, 2025
Signed-off-by: Ben Selwyn-Smith <[email protected]>
@benmss benmss force-pushed the benmss/install-libfii7-on-24.04 branch from 5e83d0c to 37e8356 Compare January 17, 2025 04:17
Signed-off-by: Ben Selwyn-Smith <[email protected]>
@benmss benmss marked this pull request as ready for review January 20, 2025 01:43
@behnazh-w behnazh-w changed the title fix: manually install libffi7 build: manually install libffi7 Jan 21, 2025
Makefile Show resolved Hide resolved
@benmss benmss force-pushed the benmss/install-libfii7-on-24.04 branch from 3104dbd to fbb7c7e Compare January 21, 2025 00:45
behnazh-w
behnazh-w previously approved these changes Jan 21, 2025
@behnazh-w behnazh-w self-requested a review January 21, 2025 01:49
@behnazh-w behnazh-w dismissed their stale review January 21, 2025 01:51

The documentation comment needs adjustment.

Makefile Outdated Show resolved Hide resolved
Signed-off-by: Ben Selwyn-Smith <[email protected]>
@behnazh-w behnazh-w changed the title build: manually install libffi7 build: install libffi7 manually Jan 21, 2025
@benmss
Copy link
Member Author

benmss commented Jan 22, 2025

The Souffle team will release an update that fixes this issue.

@benmss benmss closed this Jan 22, 2025
@benmss benmss reopened this Jan 23, 2025
@benmss
Copy link
Member Author

benmss commented Jan 23, 2025

This will be merged as a temporary fix -- to be reverted once a new version of Souffle is released.

@benmss benmss merged commit 04dbdc7 into staging Jan 23, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants