generated from oracle/template-repo
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding initial structure of telemetry jdkFeatures event generation #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
label
Dec 14, 2024
sid-srini
force-pushed
the
telemetry-jdk-features
branch
7 times, most recently
from
December 16, 2024 19:59
189d859
to
0211fb8
Compare
sid-srini
force-pushed
the
telemetry-jdk-features
branch
from
December 28, 2024 18:19
0211fb8
to
0bd6462
Compare
sid-srini
force-pushed
the
telemetry-jdk-features
branch
from
January 13, 2025 16:02
0bd6462
to
27bd556
Compare
workspace root are recognized 1. Amended LspServerTelemetryManager.sendWorkspaceInfo to use a NavigableMap to find sub-paths of the workspaceFolder that correspond to Projects, when it is not itself a Project. 2. Also, caught exceptions from ProjectProblems.isBroken() since it maybe a sign of a broken project. Signed-off-by: Siddharth Srinivasan <[email protected]>
sid-srini
force-pushed
the
telemetry-jdk-features
branch
2 times, most recently
from
January 14, 2025 00:24
07e1c26
to
e7bb560
Compare
lahodaj
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sensible to me, with a few smallish comments inline.
nbcode/telemetry/src/org/netbeans/modules/nbcode/java/lsp/server/telemetry/SourceInfo.java
Outdated
Show resolved
Hide resolved
nbcode/telemetry/src/org/netbeans/modules/nbcode/java/lsp/server/telemetry/SourceInfo.java
Outdated
Show resolved
Hide resolved
features from the NetBeans LSP Server. 1. Added nbcode.java.lsp.server.telemetry module to provide the implementation. 2. Added jdk.compiler module access to NBLS in launchOptions.ts Co-authored-by: Jan Lahoda @lahodaj Co-authored-by: Siddharth Srinivasan @sid-srini Signed-off-by: Siddharth Srinivasan <[email protected]>
sid-srini
force-pushed
the
telemetry-jdk-features
branch
from
January 20, 2025 16:27
e7bb560
to
559570c
Compare
Achal1607
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition of the java.lsp.server.telemetry module to obtain Java language features from the NetBeans LSP Server.