Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding initial structure of telemetry jdkFeatures event generation #350

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

sid-srini
Copy link
Member

@sid-srini sid-srini commented Dec 14, 2024

Addition of the java.lsp.server.telemetry module to obtain Java language features from the NetBeans LSP Server.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Dec 14, 2024
@sid-srini sid-srini force-pushed the telemetry-jdk-features branch 7 times, most recently from 189d859 to 0211fb8 Compare December 16, 2024 19:59
@sid-srini sid-srini force-pushed the telemetry-jdk-features branch from 0211fb8 to 0bd6462 Compare December 28, 2024 18:19
@sid-srini sid-srini force-pushed the telemetry-jdk-features branch from 0bd6462 to 27bd556 Compare January 13, 2025 16:02
workspace root are recognized

1. Amended LspServerTelemetryManager.sendWorkspaceInfo to use a NavigableMap
   to find sub-paths of the workspaceFolder that correspond to Projects,
   when it is not itself a Project.
2. Also, caught exceptions from ProjectProblems.isBroken() since it
   maybe a sign of a broken project.

Signed-off-by: Siddharth Srinivasan <[email protected]>
@sid-srini sid-srini force-pushed the telemetry-jdk-features branch 2 times, most recently from 07e1c26 to e7bb560 Compare January 14, 2025 00:24
@sid-srini sid-srini requested review from lahodaj and Achal1607 and removed request for lahodaj and Achal1607 January 14, 2025 00:31
Copy link
Member

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible to me, with a few smallish comments inline.

features from the NetBeans LSP Server.

1. Added nbcode.java.lsp.server.telemetry module to provide the
   implementation.
2. Added jdk.compiler module access to NBLS in launchOptions.ts

Co-authored-by: Jan Lahoda @lahodaj
Co-authored-by: Siddharth Srinivasan @sid-srini
Signed-off-by: Siddharth Srinivasan <[email protected]>
@sid-srini sid-srini force-pushed the telemetry-jdk-features branch from e7bb560 to 559570c Compare January 20, 2025 16:27
Copy link
Member

@Achal1607 Achal1607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@sid-srini sid-srini merged commit f62ab32 into oracle:telemetry Jan 21, 2025
3 checks passed
@sid-srini sid-srini deleted the telemetry-jdk-features branch January 21, 2025 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants