Refactor getter caching based on keypath state #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordangarcia
force-pushed
the
jordan/cache-improvements
branch
from
7b109de
to
b9e8621
Compare
The current version of NuclearJS uses a cache key consisting of store states (monotomically incresing ID per store). This has the disadvantage of allowing only a single level of depth when figuring out if a cache entry is stale. This leads to poor performance when the shape of a Reactor's state is more deep than wide, ie a store having multiple responsibilities for state tracking. The implementation is as follows: - Consumer can set the maxCacheDepth when instantiating a reactor - Getters are broken down into the canonical set of keypaths based on the maxCacheDepth - Add a keypath tracker abstraction to maintain the state value of all tracked keypaths - After any state change (`Reactor.__notify`) dirty keypaths are resolved and then based on which keypaths have changed any dependent observers are called
Instead of doing a full recursive traversal of the keypathStates tree, keep track of all changed paths as use that as an indicator of the paths the need to be cleaned
jordangarcia
force-pushed
the
jordan/cache-improvements
branch
from
b9e8621
to
2d6865f
Compare
|
Just curious if this is going to be merged any time soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of NuclearJS uses a cache key consisting of store
states (monotomically incresing ID per store). This has the
disadvantage of allowing only a single level of depth when figuring out
if a cache entry is stale. This leads to poor performance when the
shape of a Reactor's state is more deep than wide, ie a store having
multiple responsibilities for state tracking.
The implementation is as follows:
the maxCacheDepth
tracked keypaths
Reactor.__notify) dirty keypaths areresolved and then based on which keypaths have changed any dependent
observers are called
@loganlinn