Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jordangarcia @loganlinn
This includes the changes for the cache abstraction Logan authored and the unwatch/config options I added. API changes include:
cache
. This expects a cache constructor that conforms to the interface specified in Logan's earlier work.maxItemsToCache
. If not specified, this will default to 1000. If a number > 0, the LRU cache will cache up tomaxItemsToCache
values. If non numeric ornull
, we will default to using aBasicCache
with no item limituseCache
that defaults to true. If false, no cache values will be set.Getter
pseudo-constructor that can be used to addcache
andcacheKey
options for getters. If specified,cacheKey
will be used as the getter cache key rather than a getter reference. Valid values forcache
are['always', 'default', 'never']
. If'always'
or'never'
are specified, these options will be favored over the globaluseCache
setting.