Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSSDK-8110] chore: add sample log4j config to demo app #523

Merged
merged 3 commits into from
Sep 12, 2023

Conversation

jaeopt
Copy link
Contributor

@jaeopt jaeopt commented Jun 15, 2023

Summary

Add log4j2 dependencies and lo4j2.properties for log-level control in Example app.

Test plan

Pass existing tests

Issues

  • FSSDK-8110

Copy link
Contributor

@mnoman09 mnoman09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall changes lgtm, but I remember we removed it due to vulnerability is this version safe from that vulnerability?

@mikechu-optimizely
Copy link

@jaeopt I happened to see this PR. Do you still want it?

I think the version you're implementing is 👍 based on this CISA notice

@jaeopt
Copy link
Contributor Author

jaeopt commented Sep 11, 2023

Yes, as long as log4j version is 2.15.0 or higher, they can use it. And this sample configuration will be helpful. @muzahidul-opti

@muzahidul-opti muzahidul-opti changed the title chore: add sample log4j config to demo app [FSSDK-8110] chore: add sample log4j config to demo app Sep 12, 2023
Copy link
Contributor

@muzahidul-opti muzahidul-opti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muzahidul-opti muzahidul-opti merged commit ca2a894 into master Sep 12, 2023
14 checks passed
@muzahidul-opti muzahidul-opti deleted the jae/log4j-logger branch September 12, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants