Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(proto): update to latest proto files #183

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

dipendughosh
Copy link
Contributor

Signed-off-by: Dipendu Ghosh [email protected]

@dipendughosh dipendughosh requested a review from a team as a code owner January 17, 2024 18:15
Signed-off-by: Dipendu Ghosh <[email protected]>

Signed-off-by: dipendughosh <[email protected]>
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 354 lines in your changes are missing coverage. Please review.

Comparison is base (7231bfb) 34.82% compared to head (b6d8e33) 34.92%.

Files Patch % Lines
pydpu/proto/v1/l3_xpu_infra_mgr_pb2.py 3.06% 158 Missing ⚠️
pydpu/proto/v1/l2_xpu_infra_mgr_pb2.py 3.44% 140 Missing ⚠️
pydpu/proto/v1/networktypes_pb2.py 8.19% 56 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
+ Coverage   34.82%   34.92%   +0.10%     
==========================================
  Files          27       27              
  Lines        1944     1947       +3     
==========================================
+ Hits          677      680       +3     
  Misses       1267     1267              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -0,0 +1,4 @@
# Generated by the gRPC Python protocol compiler plugin. DO NOT EDIT!
"""Client and server classes corresponding to protobuf-defined services."""
import grpc

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'grpc' is not used.
@@ -0,0 +1,4 @@
# Generated by the gRPC Python protocol compiler plugin. DO NOT EDIT!
"""Client and server classes corresponding to protobuf-defined services."""
import grpc

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'grpc' is not used.
from google.protobuf.internal import builder as _builder
# @@protoc_insertion_point(imports)

_sym_db = _symbol_database.Default()

Check notice

Code scanning / CodeQL

Unused global variable Note

The global variable '_sym_db' is not used.
from google.protobuf.internal import builder as _builder
# @@protoc_insertion_point(imports)

_sym_db = _symbol_database.Default()

Check notice

Code scanning / CodeQL

Unused global variable Note

The global variable '_sym_db' is not used.
Copy link
Contributor

@sandersms sandersms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - one minor change to the latest is that the version of the protobuf python generator is moved to 4.25.2 from this version 4.25.1. Its only a comment change on the version of the generation function, so approving to get the latest changes in the pydpu.

@sandersms sandersms merged commit 36882b8 into opiproject:main Jan 17, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants