New rpc service to attach/detach a controller to a namespace.

Added attach/detach controller to cater to use-case of an existing customer. Signed-off-by: Vaibhav Jain <[email protected]> Signed-off-by: Michal Kalderon <[email protected]>
opiproject · Jan 26, 2023 · 1699976 · 1699976
1 parent e4b3480
commit 1699976
Show file tree

Hide file tree

Showing 19 changed files with 5,848 additions and 495 deletions.
diff --git a/storage/v1alpha1/autogen.md b/storage/v1alpha1/autogen.md
@@ -50,6 +50,7 @@
     - [NVMfRemoteControllerService](#opi_api-storage-v1-NVMfRemoteControllerService)
 
 - [frontend_nvme_pcie.proto](#frontend_nvme_pcie-proto)
+    - [ControllerNVMeNamespaceRequest](#opi_api-storage-v1-ControllerNVMeNamespaceRequest)
     - [CreateNVMeControllerRequest](#opi_api-storage-v1-CreateNVMeControllerRequest)
     - [CreateNVMeNamespaceRequest](#opi_api-storage-v1-CreateNVMeNamespaceRequest)
     - [CreateNVMeSubsystemRequest](#opi_api-storage-v1-CreateNVMeSubsystemRequest)
@@ -813,6 +814,23 @@ Back End (network-facing) APIs. NVMe/TCP and NVMe/RoCEv2 protocols are covered b
 
 
 
+<a name="opi_api-storage-v1-ControllerNVMeNamespaceRequest"></a>
+
+### ControllerNVMeNamespaceRequest
+
+
+
+| Field | Type | Label | Description |
+| ----- | ---- | ----- | ----------- |
+| subsystem | [string](#string) |  |  |
+| controller | [opi_api.common.v1.ObjectKey](#opi_api-common-v1-ObjectKey) |  |  |
+| nv_me_namespace_id | [opi_api.common.v1.ObjectKey](#opi_api-common-v1-ObjectKey) |  |  |
+
+
+
+
+
+
 <a name="opi_api-storage-v1-CreateNVMeControllerRequest"></a>
 
 ### CreateNVMeControllerRequest
@@ -1409,6 +1427,8 @@ Front End (host-facing) APIs. Mostly used for NVMe/PCIe emulation and host prese
 | ListNVMeNamespaces | [ListNVMeNamespacesRequest](#opi_api-storage-v1-ListNVMeNamespacesRequest) | [ListNVMeNamespacesResponse](#opi_api-storage-v1-ListNVMeNamespacesResponse) |  |
 | GetNVMeNamespace | [GetNVMeNamespaceRequest](#opi_api-storage-v1-GetNVMeNamespaceRequest) | [NVMeNamespace](#opi_api-storage-v1-NVMeNamespace) |  |
 | NVMeNamespaceStats | [NVMeNamespaceStatsRequest](#opi_api-storage-v1-NVMeNamespaceStatsRequest) | [NVMeNamespaceStatsResponse](#opi_api-storage-v1-NVMeNamespaceStatsResponse) |  |
+| AttachControllerNVMeNamespace | [ControllerNVMeNamespaceRequest](#opi_api-storage-v1-ControllerNVMeNamespaceRequest) | [.google.protobuf.Empty](#google-protobuf-Empty) |  |
+| DetachControllerNVMeNamespace | [ControllerNVMeNamespaceRequest](#opi_api-storage-v1-ControllerNVMeNamespaceRequest) | [.google.protobuf.Empty](#google-protobuf-Empty) |  |
 
 
 

diff --git a/storage/v1alpha1/frontend_nvme_pcie.proto b/storage/v1alpha1/frontend_nvme_pcie.proto
@@ -124,6 +124,20 @@ service FrontendNvmeService {
         option (google.api.method_signature) = "name";
     }
     rpc NVMeNamespaceStats  (NVMeNamespaceStatsRequest)  returns (NVMeNamespaceStatsResponse)  {}
+
+    rpc AttachControllerNVMeNamespace (ControllerNVMeNamespaceRequest) returns (google.protobuf.Empty) {
+        option (google.api.http) = {
+            post: "/v1/{subsystem=subsystemId/*/controller=nvmeControllerId/*}:attachControllerNvMeNamespace"
+            body: "*"
+        };
+    }
+
+    rpc DetachControllerNVMeNamespace (ControllerNVMeNamespaceRequest) returns (google.protobuf.Empty) {
+        option (google.api.http) = {
+            post: "/v1/{subsystem=subsystemId/*/controller=nvmeControllerId/*}:detachControllerNvMeNamespace"
+            body: "*"
+        };
+    }
 }
 
 message NVMeSubsystem {
@@ -398,6 +412,13 @@ message NVMeNamespaceStatsResponse {
     VolumeStats stats = 2;
 }
 
+message ControllerNVMeNamespaceRequest {
+    string subsystem = 1 [
+        (google.api.field_behavior) = REQUIRED
+    ];
+    common.v1.ObjectKey controller = 2 [(google.api.field_behavior) = REQUIRED];
+    common.v1.ObjectKey nv_me_namespace_id = 3 [(google.api.field_behavior) = REQUIRED];
+}
 // Namespace  Administrative States
 enum NVMeNamespacePciState {
     // unspecified

diff --git a/storage/v1alpha1/gen/cpp/frontend_nvme_pcie.grpc.pb.cc b/storage/v1alpha1/gen/cpp/frontend_nvme_pcie.grpc.pb.cc