Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[42811] Do not display a date picker on non date operators in cost query #17016

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

ulferts
Copy link
Contributor

@ulferts ulferts commented Oct 22, 2024

Ticket

https://community.openproject.org/wp/42811

What are you trying to accomplish?

On operators for date related filters but that themselves don't take a date as a value, display a field that is not date picker powered. In the context of the cost queries, the operator in question is the "during the last days" operator.

What approach did you choose and why?

Render an additional field that gets displayed and activated in case the operator is chosen. This is in line with the current implementation of the filter js which hides/shows values based on the arity of the operator. At the same time it, stretches the implementation to the limit of what it can hold. There is now a mix in here based on arity and type where the type is currently only used for the one operator.

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant