Prefer strings.SplitSeq over strings.Split where possible#7051
Open
caxu-rh wants to merge 1 commit intooperator-framework:masterfrom
Open
Prefer strings.SplitSeq over strings.Split where possible#7051caxu-rh wants to merge 1 commit intooperator-framework:masterfrom
caxu-rh wants to merge 1 commit intooperator-framework:masterfrom
Conversation
SplitSeq returns an iterator over the substrings rather than constructing and returning a slice, which works well in cases where we are just iterating over the result anyways. Signed-off-by: Caleb Xu <caxu@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
Replace usages of
strings.Splitwithstrings.SplitSeqin cases where we are iterating through the results; this returns an iterator over the original string, saving a slice allocation and is generally more efficient whenrangeing over it. There is no expected user-facing change in behavior.Motivation for the change:
Some slight performance improvements.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs