Fix grpc version pin comment #3452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
perdasilva
force-pushed
the
perdasilva/unpin-grpc
branch
2 times, most recently
from
7b1631a
to
688e2ac
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Signed-off-by: Per Goncalves da Silva <[email protected]>
perdasilva
force-pushed
the
perdasilva/unpin-grpc
branch
from
688e2ac
to
a22babd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
The grpc version pin comment in go.mod is not accurate. Everything should work fine with the latest grpc library. The problem is that it bumps us to go1.23, which we aren't ready for yet.
Motivation for the change:
Architectural changes:
Testing remarks:
Reviewer Checklist
/doc[FLAKE]are truly flaky and have an issue