Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Spring Boot to 3.4.1 and other dependency updates #3787

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

reta
Copy link
Contributor

@reta reta commented Jan 5, 2025

Update Spring Boot to 3.4.1 and other dependency updates

@reta reta force-pushed the dependcy.updates branch from 38aa73c to d49932c Compare January 5, 2025 17:46
@reta reta changed the title Update Srping Boot to 3.4.1 and other dependency updates Update Spring Boot to 3.4.1 and other dependency updates Jan 5, 2025
@reta reta requested a review from codefromthecrypt January 5, 2025 17:50
Copy link
Member

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only thing I would suggest is not using a minor bump as it isn't a minor-worthy change. I would expect a change in yaml or code here or downstream if it were. Basically only do a minor when some useful feature is new (bumps aren't that) or we are forced into it (like JDK forces us into a JRE floor change)

benchmarks/pom.xml Outdated Show resolved Hide resolved
Signed-off-by: Andriy Redko <[email protected]>
Copy link
Member

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gracias!

@reta reta merged commit bf6ab5a into openzipkin:master Jan 6, 2025
13 checks passed
@reta
Copy link
Contributor Author

reta commented Jan 7, 2025

@codefromthecrypt the release attempt (3.4.4) failed mid-though while uploading Docker images [1], do you think I should trigger the 3.4.5? (since Apache Maven artifacts seems to be published) Thank you.

[1] https://github.com/openzipkin/zipkin/actions/runs/12641661725/job/35224515103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants