Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: updates to armeria 1.26.3 and netty 4.1.100.Final #3614

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

codefromthecrypt
Copy link
Member

@codefromthecrypt codefromthecrypt commented Dec 5, 2023

Note: netty.version aligns with armeria

Fixes #3556

@codefromthecrypt
Copy link
Member Author

I'll bump the other main deps in another PR, as we're better off having everything updated vs whack-a-mole.

That said, I wanted to salvage @darkmastermindz's work here first.

@codefromthecrypt
Copy link
Member Author

tomorrow I will raise a PR to bump all deps except armeria/netty, so that we can close the gaps on differences to just this, without worry that some other incidental dep is impacting the topic.

codefromthecrypt pushed a commit that referenced this pull request Dec 5, 2023
This updates all main dependencies except armeria (handled #3614) and
amqp (driver is incompatible so needs a new PR).

Signed-off-by: Adrian Cole <[email protected]>
@codefromthecrypt
Copy link
Member Author

#3615 updates the other things and I'll rebase this afterwards

codefromthecrypt added a commit that referenced this pull request Dec 5, 2023
This updates all main dependencies except armeria (handled #3614) and
amqp (driver is incompatible so needs a new PR).

Signed-off-by: Adrian Cole <[email protected]>
@codefromthecrypt codefromthecrypt changed the title deps: updates armeria, jackson and micrometer deps: updates armeria and netty to latest Dec 5, 2023
@codefromthecrypt
Copy link
Member Author

pared down this PR to only include armeria+netty

@codefromthecrypt codefromthecrypt changed the title deps: updates armeria and netty to latest deps: updates armeria 1.26.3 and netty 4.1.100.Final Dec 5, 2023
@codefromthecrypt codefromthecrypt changed the title deps: updates armeria 1.26.3 and netty 4.1.100.Final deps: updates to armeria 1.26.3 and netty 4.1.100.Final Dec 5, 2023
@codefromthecrypt
Copy link
Member Author

so I checked and 1.17.2 was the highest version to not fail these health-check tests, so something changed after that

@codefromthecrypt
Copy link
Member Author

I think I maybe found it

Signed-off-by: Adrian Cole <[email protected]>
@codefromthecrypt
Copy link
Member Author

I noticed that the logs have more junk than usual, not related to this, more about spring. like ignoring our banner override in tests. I'll look into this stuff afterwards.

@codefromthecrypt codefromthecrypt merged commit e661025 into master Dec 6, 2023
9 checks passed
@codefromthecrypt codefromthecrypt deleted the armeria-bump branch December 6, 2023 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CVE-2023-38493 on direct dependency, com.linecorp.armeria:armeria
2 participants