-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: updates to armeria 1.26.3 and netty 4.1.100.Final #3614
Conversation
I'll bump the other main deps in another PR, as we're better off having everything updated vs whack-a-mole. That said, I wanted to salvage @darkmastermindz's work here first. |
606afa9
to
bf6c877
Compare
tomorrow I will raise a PR to bump all deps except armeria/netty, so that we can close the gaps on differences to just this, without worry that some other incidental dep is impacting the topic. |
This updates all main dependencies except armeria (handled #3614) and amqp (driver is incompatible so needs a new PR). Signed-off-by: Adrian Cole <[email protected]>
#3615 updates the other things and I'll rebase this afterwards |
This updates all main dependencies except armeria (handled #3614) and amqp (driver is incompatible so needs a new PR). Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: Adrian Cole <[email protected]>
bf6c877
to
5349846
Compare
pared down this PR to only include armeria+netty |
so I checked and 1.17.2 was the highest version to not fail these health-check tests, so something changed after that |
I think I maybe found it |
Signed-off-by: Adrian Cole <[email protected]>
I noticed that the logs have more junk than usual, not related to this, more about spring. like ignoring our banner override in tests. I'll look into this stuff afterwards. |
Note: netty.version aligns with armeria
Fixes #3556