Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt v2 environment keys #3595

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Adapt v2 environment keys #3595

merged 1 commit into from
Nov 16, 2023

Conversation

mrproliu
Copy link
Contributor

This PR is used to adapt in the environment variables of v2 and v3 versions.
Currently, the following two types of environment variables are not supported:

  1. XXX_ENABLED: Previously only "true" or "false", now it is "default" or "-".
  2. Environment variables that do not exist in the new version, such as mysql.host.

@mrproliu mrproliu added this to the 3.0.0 milestone Nov 16, 2023
@wu-sheng
Copy link
Member

Are docs required to change?

@mrproliu
Copy link
Contributor Author

I will write the previously compatible environment keys in the document together.

@wu-sheng wu-sheng merged commit 7cc1ee3 into openzipkin:zipkin-v3 Nov 16, 2023
8 checks passed
@mrproliu mrproliu mentioned this pull request Nov 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcchavezs jcchavezs Awaiting requested review from jcchavezs

@wu-sheng wu-sheng Awaiting requested review from wu-sheng

Assignees
No one assigned
Labels
server
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mrproliu @wu-sheng