Uses shaded netty in server jar to avoid downstream conflicts. #1788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gRPC uses Netty 4.1 and `netty-tcnative-boringssl-static`, which is sensitive to Netty versions. DataStax Cassandra driver 4.0 uses Netty 4.1, but the driver isn't out, yet. By using the published shaded jar, we can dodge the conflict for now. I've verified that we can connect to google cloud services after this change. I've also verified that there's no significant jar size change. See https://github.com/grpc/grpc-java/blob/master/SECURITY.md#netty See openzipkin/zipkin-gcp#45
8 tasks
|
pps of course I also verified cassandra still works by manually starting a zipkin server with storage type set to both versions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gRPC uses Netty 4.1 and
netty-tcnative-boringssl-static, which issensitive to Netty versions. DataStax Cassandra driver 4.0 uses Netty
4.1, but the driver isn't out, yet. By using the published shaded jar,
we can dodge the conflict for now.
I've verified that we can connect to google cloud services after this
change. I've also verified that there's no significant jar size change.
See https://github.com/grpc/grpc-java/blob/master/SECURITY.md#netty
See openzipkin/zipkin-gcp#45