ci: adds lint check, fixes yaml formatting and unnecessary auth #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adrian Cole <[email protected]>
| - name: bom | ||
| deploy_script: build-bin/deploy_bom | ||
| steps: | ||
| - name: Checkout Repository | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| # Prevent use of implicit GitHub Actions read-only token GITHUB_TOKEN. | ||
| # We push Javadocs to the gh-pages branch on commit. |
There was a problem hiding this comment.
this was a lie, as in this repo we don't!
Signed-off-by: Adrian Cole <[email protected]>
reta
approved these changes
Apr 12, 2024
|
thanks for the eye @reta! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds new scripts configure_lint and lint which work like our other build-bin scripts. These lint the workflow yaml and our markdown links.
I also removed the separate step for javadoc checking as it is easy to do that in the release test target, as well uses less resources vs doing it twice.
See openzipkin/zipkin-gcp#212 for the first impl of this.