Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable existing JUnit 4 tests and run integration tests on verify #137

Merged
merged 2 commits into from
Aug 24, 2019
Merged

Enable existing JUnit 4 tests and run integration tests on verify #137

merged 2 commits into from
Aug 24, 2019

Conversation

saturnism
Copy link
Collaborator

For #130

@saturnism saturnism changed the title Added org.junit.vintage:junit-vintage-engine to run existing JUnit 4 tests Enable existing JUnit 4 tests and run integration tests on verify Aug 23, 2019
@saturnism saturnism self-assigned this Aug 23, 2019
@saturnism
Copy link
Collaborator Author

Confirmed that the unit tests ran: https://travis-ci.org/openzipkin/zipkin-gcp/builds/575959699#L2424

Also, because publish.sh runs verify, so the existing integration test also ran: https://travis-ci.org/openzipkin/zipkin-gcp/builds/575959699#L2440

@codefromthecrypt codefromthecrypt merged commit 1ca74f3 into openzipkin:master Aug 24, 2019
@codefromthecrypt
Copy link
Member

Thanks @saturnism!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codefromthecrypt codefromthecrypt codefromthecrypt approved these changes

Assignees

@saturnism saturnism

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saturnism @codefromthecrypt