Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to latest brave version (4.3.3). #19

Merged
merged 1 commit into from
Jun 12, 2017
Merged

Updates to latest brave version (4.3.3). #19

merged 1 commit into from
Jun 12, 2017

Conversation

shimamoto
Copy link
Member

brave.Tracer.newBuilder() has been deprecated since brave 4.2.0. So fixes to provide brave.Tracing instead.

refs #18

@shimamoto shimamoto requested a review from takezoe June 12, 2017 06:31
Copy link

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This is a first step towards making play interact with Tracing's CurrentTraceContext cc @lawrencefinn

@takezoe takezoe merged commit 12d78b4 into master Jun 12, 2017
@shimamoto shimamoto deleted the brave-4.3 branch June 12, 2018 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants