Support Ratpack 1.6 #8
Comments
|
@llinder I haven't create an issue for hyleung/ratpack-zipkin#44 yet cos I'm not sure whether it should be part of the upgrade to Ratpack 1.6 or whether it makes more sense to just the 1.6 upgrade and then rework the http client tracing or try to split the two things. |
llinder
added a commit
that referenced
this issue
Jul 25, 2019
Drops the wrapped HttpClient instrumentation and uses HttpClient Interceptors instead. This changes the trace results slightly based on the way the Ratpack Interceptor is invoked. In practice this shouldn't be an issue but if we get complaints we can alway introduce an optional library with the wrapped HttpClient implementation down the road. By using the Ratpack Interceptor we can close out #8 and it should also fix #27 as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Migrated from hyleung/ratpack-zipkin#64
Ratpack 1.6 is out and should include a client interceptor API now. I suspect we will get better milage from using the interceptors and hope that it may also fix some anomalies around client tracing that have been seen under heavy load.
The text was updated successfully, but these errors were encountered: