Skip to content
This repository has been archived by the owner on Jan 3, 2019. It is now read-only.

Revisit Http client tracing now that Ratpack has interceptors #44

Closed
hyleung opened this issue Oct 7, 2017 · 1 comment
Closed

Revisit Http client tracing now that Ratpack has interceptors #44

hyleung opened this issue Oct 7, 2017 · 1 comment

Comments

@hyleung
Copy link
Owner

hyleung commented Oct 7, 2017

The current implementation for tracing http client requests, while it works, is a bit clunky. Much of the yak shaving was because, at the time, Ratpack didn't have any way of intercepting http client requests/responses.

With ratpack/ratpack#1124, Ratpack has added support for interceptors.

We should revisit the current client tracing implementation to see if we can get rid of some of the extra code.

Note: I tried this a little while ago when that Ratpack PR was first merged but ran into some issues with accessing the context from a non-Ratpack managed thread. This may require a little refactoring to get working properly.

@hyleung
Copy link
Owner Author

hyleung commented Jan 3, 2019

Just gonna close this since it's dependent on on openzipkin-contrib/brave-ratpack#8 now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant