HTML document can be retrieved as fetch
#406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoit74
force-pushed
the
html_as_fetch
branch
from
80e8ee4 to
025385b
Compare
Nota: the two on content and mimetype are just linked to openzim/python-scraperlib#196 and will have to be reverted once this issue is fixed
benoit74
force-pushed
the
html_as_fetch
branch
from
025385b to
3c7363f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #405
Also contains a commit with test website changes for #403 (which might be only an upstream issue in the end, but always good to have test case on test website for that).
Also fixes type hints linked to recent python-libzim changes (the two later one are linked to openzim/python-scraperlib#196 and will have to be reverted one this issue is fixed).