Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unfold collapsible tables for Desktop and Mobile renders #1934

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Unfold collapsible tables for Desktop and Mobile renders #1934

wants to merge 1 commit into from

Conversation

VadimKovalenkoSNF
Copy link
Collaborator

@VadimKovalenkoSNF VadimKovalenkoSNF commented Oct 25, 2023 •
edited
Loading

Fixes #1911

@VadimKovalenkoSNF VadimKovalenkoSNF self-assigned this Oct 26, 2023
@kelson42
Copy link
Collaborator

@VadimKovalenkoSNF What is the status here? You have hardcoded some CSS rules, but why these rules are not in the dependences scraped by MWoffliner?

@VadimKovalenkoSNF
Copy link
Collaborator Author

@kelson42 The property display: none comes from site.styles, check https://en.wikipedia.org/w/load.php?debug=true&lang=en&modules=site.styles&only=styles&skin=vector . So to display table I had to override this rule. This is a part of generic CSS modules so it applies to all renders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@VadimKovalenkoSNF VadimKovalenkoSNF

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Collapsed tables are not viewable
2 participants
@VadimKovalenkoSNF @kelson42