Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to libzim7 #1702

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Move to libzim7 #1702

wants to merge 3 commits into from

Conversation

kelvinhammond
Copy link
Collaborator

@kelvinhammond kelvinhammond commented Dec 31, 2022

node-libzim's declartions file needs to be updated for this to work as this project is using an older version of typescript and upgrading that turned out to be more than I was willing to do.

node-libzim pull request openzim/node-libzim#88

@kelson42 There is one failing test that I've not been able to fix, do you have someone else that can take a look?
I wrote the buffer to a file and it seems corrupted but the other tests pass so I wonder if its something with the node-libzim, or libzim, or just an error in the test itself.

    TypeError: Cannot read properties of undefined (reading 'mime')                                                                                                                                                                           
        at /code/mwoffliner/test/unit/webpAndRedirection.test.ts:64:48                                                                                                                                                              
        at Generator.next (<anonymous>)                                                                                                                                                                                                       
        at fulfilled (/code/mwoffliner/test/unit/webpAndRedirection.test.ts:5:58)                                                                                                                                                                                                                                                                                                                                                                                        
    ✖ passed test for png                                                                                                                                                                                                                     
    ----------------------                                                                                                                                                                                                                    
      operator: ok                                                                                                                                                                                                                            
      expected: true                                                                                                                                                                                                                          
      actual:   false                                                                                                                                                                                                                         
      at: <anonymous> (/code/mwoffliner/test/unit/webpAndRedirection.test.ts:51:7)                                                                                                                                                  
      stack: |-                                                                                                                                                                                                                               
  Error: passed test for png                                                                                                                                                                                                                  
  at Test.assert [as _assert] (/code/mwoffliner/node_modules/tape/lib/test.js:228:54)                                                                                                                                               
  at Test.bound [as _assert] (/code/mwoffliner/node_modules/tape/lib/test.js:80:32)                                                                                                                                                 
  at Test.assert (/code/mwoffliner/node_modules/tape/lib/test.js:347:10)                                                                                                                                                            
  at Test.bound [as assert] (/code/mwoffliner/node_modules/tape/lib/test.js:80:32)                                                                                                                                                  
  at /code/mwoffliner/test/unit/webpAndRedirection.test.ts:51:7                                                                                                                                                                     
  at Generator.next (<anonymous>)                                                                                      
  at fulfilled (/code/mwoffliner/test/unit/webpAndRedirection.test.ts:5:58) 

@kelson42
Copy link
Collaborator

kelson42 commented Jan 1, 2023

@kelvinhammond Thank you very much for this PR. Super glad to see it. Not sure about the CI problem, but indeed I could have a look. The big problem is that latest node-libzim 3.0.0 is not released yet because segmentation fault.

@rgaudin rgaudin removed their request for review January 2, 2023 10:47
@stale
Copy link

stale bot commented May 26, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants