Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get real cover page of books #70

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Get real cover page of books #70

merged 1 commit into from
Nov 19, 2024

Conversation

benoit74
Copy link
Contributor

@benoit74 benoit74 commented Nov 13, 2024

Fix #68

Nota:

@benoit74 benoit74 self-assigned this Nov 13, 2024
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 24.24242% with 25 lines in your changes missing coverage. Please review.

Project coverage is 43.86%. Comparing base (71be961) to head (5aaf93f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
scraper/src/mindtouch2zim/client.py 24.24% 25 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
- Coverage   44.01%   43.86%   -0.16%     
==========================================
  Files          15       15              
  Lines         936      953      +17     
  Branches      128      131       +3     
==========================================
+ Hits          412      418       +6     
- Misses        511      522      +11     
  Partials       13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@benoit74 benoit74 marked this pull request as ready for review November 13, 2024 15:33
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from index_page to main November 19, 2024 07:45
@benoit74 benoit74 merged commit f3d6b9a into main Nov 19, 2024
10 checks passed
@benoit74 benoit74 deleted the cover_page branch November 19, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Libretexts: get real cover page
2 participants