Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #64

Merged
merged 4 commits into from
Nov 11, 2024
Merged

Cleanup #64

merged 4 commits into from
Nov 11, 2024

Conversation

benoit74
Copy link
Contributor

@benoit74 benoit74 commented Nov 8, 2024

Fix #26
Partial work of #36

@benoit74 benoit74 self-assigned this Nov 8, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 26.66667% with 11 lines in your changes missing coverage. Please review.

Project coverage is 45.08%. Comparing base (a3b696e) to head (eaeb39a).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
scraper/src/mindtouch2zim/processor.py 9.09% 10 Missing ⚠️
scraper/src/mindtouch2zim/asset.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
- Coverage   45.22%   45.08%   -0.15%     
==========================================
  Files          13       13              
  Lines         849      845       -4     
  Branches      111      111              
==========================================
- Hits          384      381       -3     
+ Misses        452      451       -1     
  Partials       13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 marked this pull request as ready for review November 8, 2024 20:13
@benoit74 benoit74 requested a review from rgaudin November 8, 2024 20:13
Base automatically changed from image_compression to main November 11, 2024 10:48
@benoit74 benoit74 merged commit 147f27c into main Nov 11, 2024
10 checks passed
@benoit74 benoit74 deleted the cleanup branch November 11, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "boilerplate" add_item_for
2 participants