-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put memory consumption under control #109
base: ui_enhancements
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ui_enhancements #109 +/- ##
===================================================
+ Coverage 44.19% 44.26% +0.06%
===================================================
Files 20 20
Lines 1163 1168 +5
Branches 168 169 +1
===================================================
+ Hits 514 517 +3
- Misses 637 639 +2
Partials 12 12 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ; see simplification suggestion
image, | ||
[ | ||
int( | ||
math.sqrt( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why using this? There are resize options that keep aspect ratio and you just pass the largest one (so the other one fits)
Can you rename PR? |
Fix #90
Changes: